DPL: use C++26 extension to expand packs where available#15631
Open
ktf wants to merge 1 commit into
Open
Conversation
Member
Author
|
@aalkin not sure I would merge this just yet, however it seems to work as desired... :-) |
aalkin
reviewed
Jul 23, 2026
| if constexpr (sizeof...(members) == 0) { | ||
| return std::array<bool, 0>(); | ||
| } else { | ||
| return std::array<detail::first_t<decltype(l(members))...>, sizeof...(members)>{l(members)...}; |
Member
There was a problem hiding this comment.
You can skip the array's template parameters, they should be deducible from the initializer list
Member
|
If we switch to clang as a primary compiler for O2Physics, this will work not only on mac. |
O(1) in both CPU and time rather than O(N) when compiling the pack expansion. Removes the limit to 100 elements in a struct. Requires XCode 26.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O(1) in both CPU and time rather than O(N) when compiling the pack expansion.
Removes the limit to 100 elements in a struct.
Requires XCode 26.4