Mergers: actually collect only mergeable objects belonging to TCanvas#15555
Open
knopers8 wants to merge 1 commit into
Open
Mergers: actually collect only mergeable objects belonging to TCanvas#15555knopers8 wants to merge 1 commit into
knopers8 wants to merge 1 commit into
Conversation
We were seeing warnings like below when merging certain TCanvases: ``` W 11 Object 'title' with type 'TPaveText' is not one of the mergeable types, skipping W 11 Object 'TPave' with type 'TLegend' is not one of the mergeable types, skipping W 11 Object 'TFrame' with type 'TFrame' is not one of the mergeable types, skipping ``` It is perfectly OK to have some TPaveText in a canvas and expect to have just the histogram merged, but the text should remain as it was, so there is no reason to produce warnings. The change ensures that collectUnderlyingObject actually collects just the mergeable objects from TCanvas, as promised in the documentation. Fixes QC-1344.
Collaborator
Author
|
Needs #15554 to successfully compile. |
justonedev1
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were seeing warnings like below when merging certain TCanvases:
It is perfectly OK to have some TPaveText in a canvas and expect to have just the histogram merged, but the text should remain as it was, so there is no reason to produce warnings.
The change ensures that collectUnderlyingObject actually collects just the mergeable objects from TCanvas, as promised in the documentation.
Fixes QC-1344.