DPL: add metric aggregation based on policies#15495
Open
robertpaulp wants to merge 1 commit into
Open
Conversation
ktf
reviewed
Jun 8, 2026
| CPU = 0; \ | ||
| } | ||
| #endif | ||
| #define O2_METRICAGGREGATOR_INTERVAL 30 |
Member
There was a problem hiding this comment.
Make this a runtime option, please, or reuse the dumpInterval. Also, does it make sense that every metric aggregates with the same interval?
ktf
reviewed
Jun 8, 2026
| @@ -0,0 +1,397 @@ | |||
| // Copyright 2019-2025 CERN and copyright holders of ALICE O2. | |||
Member
There was a problem hiding this comment.
Before you write a separate class, I would like to be convinced this cannot be an additional operation on the DataProcessingStats.
ktf
reviewed
Jun 8, 2026
| driverInfo.resourcesMonitoringDumpInterval * 1000); | ||
| } | ||
|
|
||
| if (std::getenv("ALIEN_JDL_AGGREGATOR_POLICY") != nullptr) { |
Member
There was a problem hiding this comment.
Do you really need a separate timer?
ktf
reviewed
Jun 8, 2026
|
|
||
| const char* MetricAggregator::getBackendFromEnv() | ||
| { | ||
| const char* envBackend = std::getenv("APMON_CONFIG"); |
Member
There was a problem hiding this comment.
why does it need to know about APMON at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a metric aggregation tool. The tool offers a configurable initialization, where for specific devices or metrics a type of policy can be chosen. The following pipeline is done:
O2_METRICAGGREGATOR_INTERVAL.