Skip to content

fix warning final-dtor-non-final-class#15490

Open
f3sch wants to merge 1 commit into
AliceO2Group:devfrom
f3sch:fix/warn/dtor
Open

fix warning final-dtor-non-final-class#15490
f3sch wants to merge 1 commit into
AliceO2Group:devfrom
f3sch:fix/warn/dtor

Conversation

@f3sch
Copy link
Copy Markdown
Collaborator

@f3sch f3sch commented Jun 4, 2026

Fixes these compilation warnings that started showing up after updating:

2026-06-04@21:16:17:DEBUG:O2:O2:0: /Users/f3sch/git/alice/sw/SOURCES/O2/dev_head/0/Detectors/EMCAL/base/include/EMCALBase/NonlinearityHandler.h:202:43: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
2026-06-04@21:16:17:DEBUG:O2:O2:0:   191 |   class FunctionNotFoundExcpetion : public std::exception
2026-06-04@21:16:17:DEBUG:O2:O2:0:       |                                   final
2026-06-04@21:16:17:DEBUG:O2:O2:0:   192 |   {
2026-06-04@21:16:17:DEBUG:O2:O2:0:   193 |    public:
2026-06-04@21:16:17:DEBUG:O2:O2:0:   194 |     /// \brief Constructor
2026-06-04@21:16:17:DEBUG:O2:O2:0:   195 |     /// \param Name of the nonlinearity function raising the exception
2026-06-04@21:16:17:DEBUG:O2:O2:0:   196 |     FunctionNotFoundExcpetion(const std::string_view name) : mName(name), mMessage()
2026-06-04@21:16:17:DEBUG:O2:O2:0:   197 |     {
2026-06-04@21:16:17:DEBUG:O2:O2:0:   198 |       mMessage = "Nonlinearity funciton " + mName + " not found";
2026-06-04@21:16:17:DEBUG:O2:O2:0:   199 |     }
2026-06-04@21:16:17:DEBUG:O2:O2:0:   200 |
2026-06-04@21:16:17:DEBUG:O2:O2:0:   201 |     /// \brief Destructor
2026-06-04@21:16:17:DEBUG:O2:O2:0:   202 |     ~FunctionNotFoundExcpetion() noexcept final = default;
2026-06-04@21:16:17:DEBUG:O2:O2:0:       |                                           ^

@f3sch
fix warning final-dtor-non-final-class
38b36cd 
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@arossi81 arossi81 Awaiting requested review from arossi81 arossi81 is a code owner

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@wiechula wiechula Awaiting requested review from wiechula wiechula is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

@peressounko peressounko Awaiting requested review from peressounko peressounko is a code owner

@kharlov kharlov Awaiting requested review from kharlov kharlov is a code owner

@fprino fprino Awaiting requested review from fprino fprino is a code owner

@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner

@maxrauch maxrauch Awaiting requested review from maxrauch maxrauch is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@matthiasrichter matthiasrichter Awaiting requested review from matthiasrichter matthiasrichter is a code owner

@nstrangm nstrangm Awaiting requested review from nstrangm nstrangm is a code owner

@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@f3sch