Skip to content

DPL Analysis: return unsafe cursor when reserving #15450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktf wants to merge 1 commit into
base: dev
Choose a base branch
from
+25 −1
Open

DPL Analysis: return unsafe cursor when reserving #15450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Framework/Core/include/Framework/AnalysisHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,12 @@ struct WritingCursor {

/// reserve @a size rows when filling, so that we do not
/// spend time reallocating the buffers.
void reserve(int64_t size)
/// Returns an unsafe cursor that skips capacity checks
/// (safe because we just reserved enough space).
auto reserve(int64_t size)
{
mBuilder->reserve(typename persistent_table_t::column_types{}, size);
return FFL(mBuilder->template unsafeCursor<persistent_table_t>());
}

void release()
Expand Down
21 changes: 21 additions & 0 deletions Framework/Core/include/Framework/TableBuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,18 @@ class TableBuilder
};
}

/// Same as persist, but uses UnsafeAppend (no capacity check).
/// Only safe after reserve() has been called with the correct size.
template <typename ARG0, typename... ARGS>
requires(sizeof...(ARGS) > 0) || ShouldNotDeconstruct<ARG0>
auto unsafePersist()
{
using FillTuple = std::tuple<typename BuilderMaker<ARG0>::FillType, typename BuilderMaker<ARGS>::FillType...>;
return [holders = mHolders](unsigned int /*slot*/, typename BuilderMaker<ARG0>::FillType arg, typename BuilderMaker<ARGS>::FillType... args) -> void {
TableBuilderHelpers::unsafeAppend(*(HoldersTupleIndexed<ARG0, ARGS...>*)holders, std::forward_as_tuple(arg, args...));
};
}

// Same as above, but starting from a o2::soa::Table, which has all the
// information already available.
template <typename T>
Expand All @@ -725,6 +737,15 @@ class TableBuilder
}(typename T::table_t::persistent_columns_t{});
}

/// Same as cursor(), but uses UnsafeAppend. Only safe after reserve().
template <typename T>
auto unsafeCursor()
{
return [this]<typename... Cs>(pack<Cs...>) {
return this->template unsafePersist<typename Cs::type...>();
}(typename T::table_t::persistent_columns_t{});
}

template <typename... Cs>
auto cursor(framework::pack<Cs...>)
{
Expand Down