Skip to content

[EMCAL-1135] Throw exception in case starttime is to large or small#13369

Merged
mfasDa merged 1 commit into
AliceO2Group:devfrom
jokonig:EMCAL-1135
Aug 14, 2024
Merged

[EMCAL-1135] Throw exception in case starttime is to large or small#13369
mfasDa merged 1 commit into
AliceO2Group:devfrom
jokonig:EMCAL-1135

Conversation

@jokonig

@jokonig jokonig commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

@jokonig jokonig requested a review from mfasDa as a code owner August 12, 2024 11:12
@github-actions

Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

mfasDa
mfasDa previously approved these changes Aug 12, 2024

@mfasDa mfasDa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mfasDa
mfasDa previously approved these changes Aug 12, 2024
@jokonig jokonig changed the title [WIP] [EMCAL-1135] Throw exception in case starttime is to large or small [EMCAL-1135] Throw exception in case starttime is to large or small Aug 12, 2024
- This commit is an extention for PR: AliceO2Group#13326
- Move error class from base to reconstruction
- added handling of error RawToCell converter: handleFastORStartTimeErrors
- add error type to TRUDecodingError to indicate invalid starttime
@mfasDa mfasDa merged commit d921a17 into AliceO2Group:dev Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants