Skip to content

[EMCAL-1135] Throw exception in case of to large starttime for TRU channel#13326

Merged
mfasDa merged 1 commit into
AliceO2Group:devfrom
jokonig:EMCAL-1135
Aug 2, 2024
Merged

[EMCAL-1135] Throw exception in case of to large starttime for TRU channel#13326
mfasDa merged 1 commit into
AliceO2Group:devfrom
jokonig:EMCAL-1135

Conversation

@jokonig

@jokonig jokonig commented Jul 25, 2024

Copy link
Copy Markdown
Collaborator
  • A case was found where the starttime was larger than the maximum possible bunch length of a TRU channel
  • For REC channel, the maximum length is 15, while for TRU channel, it is 14.
  • A possible bit-flip could cause a FEC channel to be flagged as TRU channel, however if that channel than has a starttime of 14, it will write into unallocated memory as it exceeds the length of the vector
  • Added an exception and implemented a unit test for the exception

@jokonig jokonig requested a review from mfasDa as a code owner July 25, 2024 12:29
@github-actions

github-actions Bot commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

[EMCAL-1135] Throw exception in case of to large starttime for TRU ch…
cc3d4fd 
…annel

- A case was found where the starttime was larger than the maximum possible bunch length of a TRU channel
- For REC channel, the maximum length is 15, while for TRU channel, it is 14.
- A possible bit-flip could cause a FEC channel to be flagged as TRU channel, however if that channel than has a starttime of 14, it will write into unallocated memory as it exceeds the length of the vector
- Added an exception and implemented a unit test for the exception
@jokonig jokonig changed the title [WIP][EMCAL-1135] Throw exception in case of to large starttime for TRU channel [EMCAL-1135] Throw exception in case of to large starttime for TRU channel Jul 25, 2024
@alibuild

alibuild commented Jul 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for cc3d4fd at 2024-07-29 11:11:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.log[ERROR] Workflow crashed - PID 16765 (tof-matcher) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device tof-matcher: pid 16765 (exit 128)
./sim-challenge.log[ERROR] SEVERE: Device tof-matcher (16765) returned with 128
./midreco.log[12621:MIDRecoWriter]: [09:10:00][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[6473:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[6475:Digitizations]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[6471:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
[0 more errors; see full log]

Full log here.

mfasDa
mfasDa approved these changes Aug 2, 2024
View reviewed changes

@mfasDa mfasDa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mfasDa mfasDa merged commit 05f1457 into AliceO2Group:dev Aug 2, 2024
jokonig pushed a commit to jokonig/AliceO2 that referenced this pull request Aug 12, 2024
[EMCAL-1135] Throw exception in case starttime is to large or small
4bd5765 
- This commit is an extention for PR: AliceO2Group#13326
- Move error class from base to reconstruction
- added handling of error RawToCell converter: handleFastORStartTimeErrors
- add error type to TRUDecodingError to indicate invalid starttime
@jokonig jokonig mentioned this pull request Aug 12, 2024
Merged
jokonig pushed a commit to jokonig/AliceO2 that referenced this pull request Aug 12, 2024
[EMCAL-1135] Throw exception in case starttime is to large or small
d0058b8 
- This commit is an extention for PR: AliceO2Group#13326
- Move error class from base to reconstruction
- added handling of error RawToCell converter: handleFastORStartTimeErrors
- add error type to TRUDecodingError to indicate invalid starttime
jokonig pushed a commit to jokonig/AliceO2 that referenced this pull request Aug 12, 2024
[EMCAL-1135] Throw exception in case starttime is to large or small
fc869da 
- This commit is an extention for PR: AliceO2Group#13326
- Move error class from base to reconstruction
- added handling of error RawToCell converter: handleFastORStartTimeErrors
- add error type to TRUDecodingError to indicate invalid starttime
mfasDa pushed a commit that referenced this pull request Aug 14, 2024
@jokonig
[EMCAL-1135] Throw exception in case starttime is to large or small (#…
d921a17 
…13369)

- This commit is an extention for PR: #13326
- Move error class from base to reconstruction
- added handling of error RawToCell converter: handleFastORStartTimeErrors
- add error type to TRUDecodingError to indicate invalid starttime

Co-authored-by: jokonig <jokonig@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfasDa mfasDa mfasDa approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jokonig @alibuild @mfasDa