[FOCAL-66] ECAL geoemetry and step manager for pads#13249
Conversation
[FOCAL-66] ECAL geometry and step manager for pads
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
mfasDa
left a comment
There was a problem hiding this comment.
I think the most important change needed is to outsource the Hit processing of the separate subsystems to dedicated functions ProcessHitsEPad, ProcessHitsEPixel, ProcessHitsHCAL, for 2 reasons:
a) The check for minimal energy deposit might shadow other subsystems, if they are in a combined process function
b) We would like to be able to switch off subsystems via the o2::ConfigurableParams class to run ECAL or HCAL alone (i.e. for testbeam simulation)
Otherwise I think the PR is already in a good shape and soon ready to be merged.
|
Error while checking build/O2/fullCI for 547b62e at 2024-07-04 09:30: Full log here. |
Added ProcessHItsECAL and ProcessHitHCAL methods.
Split ProcessHit to ProcessHitECAL and ProcssHitHCAL.
…sHits Added sensitive volume for Pixels. Minor changes in geometry - splitting of Pads and Pixels. Additional method for Pixels responsible for ProcessHits in Pixels.
mfasDa
left a comment
There was a problem hiding this comment.
There is one small issue left:
The vector "mSensitive..." we use to declare all FOCAL volumes as sensitive - in order to build the decay tree and not to have broken chains. For this one single container is sufficient - currently the top volume is declared 3 times as sensitive, for each subsystem. The real sensitive volume, for which hits are created, is anyhow handled differently.
One sensitive volume list instead of three for HCAL, Pads Pixels.
mfasDa
left a comment
There was a problem hiding this comment.
Now looks good and ready to merge.
Head branch was pushed to by a user without write access
|
I've added missing string method c_srt() to logs. |
[FOCAL-66] ECAL geometry and step manager for pads