CCDB: Ensure CCDBDownloader's libuv loop is properly deleted - #13238
Merged
Conversation
knopers8
requested review from
a team,
Barthelemy,
costing and
sawenzel
as code owners
June 20, 2024 13:51
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
My valgrind checks were showing that the internal CCDBDownloader's libuv loop resources were not fully released. With this fix, valgrind is happy. The change is based on the following premises: - `uv_loop_alive` returns true if there are *active* handles - `uv_loop_close` returns `UV_EBUSY` if there are *open* handles. - we need to succesfully call `uv_loop_close` to clear `mUVLoop` resources Thus, in case that we would not have *active* handles, we would never close *open* ones, and consequently would not manage to call `uv_loop_close` without getting `UV_EBUSY`.
Collaborator
|
Thank you @knopers8 ! Informing @TrifleMichael of the change. |
sawenzel
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My valgrind checks were showing that the internal CCDBDownloader's libuv loop resources were not fully released. With this fix, valgrind is happy.
The change is based on the following premises:
uv_loop_alivereturns true if there are active handlesuv_loop_closereturnsUV_EBUSYif there are open handles.uv_loop_closeto clearmUVLoopresourcesThus, in case that we would not have active handles, we would never close open ones, and consequently would not manage to call
uv_loop_closewithout gettingUV_EBUSY.