Skip to content

[WIP] CCDB api import from QC (O2-347)#1321

Merged
Barthelemy merged 11 commits into
AliceO2Group:devfrom
Barthelemy:feature-ccdb-api
Sep 13, 2018
Merged

[WIP] CCDB api import from QC (O2-347)#1321
Barthelemy merged 11 commits into
AliceO2Group:devfrom
Barthelemy:feature-ccdb-api

Conversation

@Barthelemy

Copy link
Copy Markdown
Collaborator

No description provided.

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

This is a PR to move the CCDB api with curl that I wrote for the QC to O2. This is provided as is. I made it compliant with Coding Standard and provided a set of functional tests that rely on ccdb-test.cern.ch:8080.
I have added documentation in the README and commented the code with doxygen.

@Barthelemy Barthelemy requested a review from costing September 11, 2018 07:33
* @param startValidityTimestamp Start of validity. If omitted, current timestamp is used.
* @param endValidityTimestamp End of validity. If omitted, current timestamp + 1 year is used.
*/
void store(TObject* rootObject, std::string path, std::map<std::string, std::string> metadata,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to return the newly created object ID / path from the store() method

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the idea but fail to implement it. I tried to use

    std::string requestOutput;
    curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlWrite_CallbackFunc_StdString);
    curl_easy_setopt(curl, CURLOPT_WRITEDATA, &requestOutput);

It works in the method list() but here it does not. Probably because of the multipart or because of the redirection.

I propose to keep it as a future improvement if you don't mind.

@sawenzel

Copy link
Copy Markdown
Collaborator

@dberzano : Seems like the macos CI is down.

@dberzano

Copy link
Copy Markdown
Contributor

Yes, I know, it's restarting; an update was installed by the machine owner and the node was rebooted.

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

@dberzano When I click to see the details of the macos failure, I get a 404.

@Barthelemy

Copy link
Copy Markdown
Collaborator Author

I have to work on the macos issue, not sure what is going on.

@Barthelemy Barthelemy merged commit 41431f7 into AliceO2Group:dev Sep 13, 2018
mikesas pushed a commit to mikesas/AliceO2 that referenced this pull request Dec 13, 2022
Co-authored-by: Alessandro Balbino <alessandro.balbino@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants