SIM: Adding experiment versions and dynamic library loading#13148
Merged
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
96c037a to
ccde71a
Compare
Collaborator
|
Thanks. Will take a look. |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Collaborator
Author
|
Hi @sawenzel, I update the code and the help description AFAICT it does what we discussed. Maybe after testing, should I undraft to test CI? |
Collaborator
|
Thanks. Already took away the draft status. Will test it once more then merge it. |
Collaborator
|
PR is fine for me. Only problem is the build/AliceO2/O2/o2/macOS-arm CI. Some macros seem to fail... should probably take a look. @ktf : Is this a known problem ? |
Member
|
The mac issue is not a known problem (or better, there was a known issue that got hopefully fixed which was masking this other one, I guess). I need to check what is going on. |
Member
|
Actually, I think it's a problem with this PR. It looks like a clash between boost filesystem and std::filesystem. |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Collaborator
|
Error while checking build/O2/fullCI for 569748d at 2024-05-27 23:01: Full log here. |
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Collaborator
Author
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Collaborator
|
Works fine for me. Thanks a lot for this development. Merging. |
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* SIM: Add detectorList option:
Gaining more flexibility with detector geometries.
(a) Allows to select a detector list
from a pre-defined list of ALICE2, ALICE2.1, ALICE3 (corresponding to Run3, Run4, Run5).
Arguments for -m, --skipModules, --readoutDetectors will then be checked against that list.
`o2-sim -n 1 --detectorList ALICE2.1 -m IT3 -o bar2`
(b) Allows to define a custom detector list "MyList" in a JSON file, and following the notation:
`o2-sim --detectorList MyList:${PWD}/myDetector.json`
* SIM: Add dynamic detector library loading
This commit also adds the possibility to instantiate/construct detector modules as a dynamic plugin.
The benefit is that we no longer need to link all possible detector libraries into the simulation executable.
(cherry picked from commit be5cdb9)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* SIM: Add detectorList option:
Gaining more flexibility with detector geometries.
(a) Allows to select a detector list
from a pre-defined list of ALICE2, ALICE2.1, ALICE3 (corresponding to Run3, Run4, Run5).
Arguments for -m, --skipModules, --readoutDetectors will then be checked against that list.
`o2-sim -n 1 --detectorList ALICE2.1 -m IT3 -o bar2`
(b) Allows to define a custom detector list "MyList" in a JSON file, and following the notation:
`o2-sim --detectorList MyList:${PWD}/myDetector.json`
* SIM: Add dynamic detector library loading
This commit also adds the possibility to instantiate/construct detector modules as a dynamic plugin.
The benefit is that we no longer need to link all possible detector libraries into the simulation executable.
(cherry picked from commit be5cdb9)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* SIM: Add detectorList option:
Gaining more flexibility with detector geometries.
(a) Allows to select a detector list
from a pre-defined list of ALICE2, ALICE2.1, ALICE3 (corresponding to Run3, Run4, Run5).
Arguments for -m, --skipModules, --readoutDetectors will then be checked against that list.
`o2-sim -n 1 --detectorList ALICE2.1 -m IT3 -o bar2`
(b) Allows to define a custom detector list "MyList" in a JSON file, and following the notation:
`o2-sim --detectorList MyList:${PWD}/myDetector.json`
* SIM: Add dynamic detector library loading
This commit also adds the possibility to instantiate/construct detector modules as a dynamic plugin.
The benefit is that we no longer need to link all possible detector libraries into the simulation executable.
(cherry picked from commit be5cdb9)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* SIM: Add detectorList option:
Gaining more flexibility with detector geometries.
(a) Allows to select a detector list
from a pre-defined list of ALICE2, ALICE2.1, ALICE3 (corresponding to Run3, Run4, Run5).
Arguments for -m, --skipModules, --readoutDetectors will then be checked against that list.
`o2-sim -n 1 --detectorList ALICE2.1 -m IT3 -o bar2`
(b) Allows to define a custom detector list "MyList" in a JSON file, and following the notation:
`o2-sim --detectorList MyList:${PWD}/myDetector.json`
* SIM: Add dynamic detector library loading
This commit also adds the possibility to instantiate/construct detector modules as a dynamic plugin.
The benefit is that we no longer need to link all possible detector libraries into the simulation executable.
(cherry picked from commit be5cdb9)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* SIM: Add detectorList option:
Gaining more flexibility with detector geometries.
(a) Allows to select a detector list
from a pre-defined list of ALICE2, ALICE2.1, ALICE3 (corresponding to Run3, Run4, Run5).
Arguments for -m, --skipModules, --readoutDetectors will then be checked against that list.
`o2-sim -n 1 --detectorList ALICE2.1 -m IT3 -o bar2`
(b) Allows to define a custom detector list "MyList" in a JSON file, and following the notation:
`o2-sim --detectorList MyList:${PWD}/myDetector.json`
* SIM: Add dynamic detector library loading
This commit also adds the possibility to instantiate/construct detector modules as a dynamic plugin.
The benefit is that we no longer need to link all possible detector libraries into the simulation executable.
(cherry picked from commit be5cdb9)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* SIM: Add detectorList option:
Gaining more flexibility with detector geometries.
(a) Allows to select a detector list
from a pre-defined list of ALICE2, ALICE2.1, ALICE3 (corresponding to Run3, Run4, Run5).
Arguments for -m, --skipModules, --readoutDetectors will then be checked against that list.
`o2-sim -n 1 --detectorList ALICE2.1 -m IT3 -o bar2`
(b) Allows to define a custom detector list "MyList" in a JSON file, and following the notation:
`o2-sim --detectorList MyList:${PWD}/myDetector.json`
* SIM: Add dynamic detector library loading
This commit also adds the possibility to instantiate/construct detector modules as a dynamic plugin.
The benefit is that we no longer need to link all possible detector libraries into the simulation executable.
(cherry picked from commit be5cdb9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sawenzel, this a draft based on our discussion to have the possibility to specify the detectors via list.
The first commit introduces two new program options, namely
detectorVersion versionanddetectorVersionJSON fileand the relevant parsing. Two cases are covered:detectorVersionspecify: then the version is taken from a predefined map with 'official' versionsAFAICT this 'works' but I did not test this really thoroughly but running 'o2-sim' with different options seems to do what I want.
The second commit introduces dynamic library loading with a custom dll manager modelled as a singleton. As an example I removed the dependency on 'O2{ITS,TPC,TRK}Simulation' which works as expected and I think can be extended to most other detector simulation libraries. I do not have much experience with this and was more fun experiment :).