ITS efficiency maps protection for digitization out of range by nicolovalle · Pull Request #12889 · AliceO2Group/AliceO2

nicolovalle · 2024-03-19T12:47:01Z

Changing function called by the digitizer.
The time-evolving part of the map is not decoded if the difference between "requested orbit" and "found orbit" is larger than ~30 sec: only the chips contained in the static part are masked.

cc @iravasen @mcoquet642

+async-label async-mc

github-actions · 2024-03-19T12:47:14Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

nicolovalle · 2024-03-19T12:53:14Z

+async-label async-mc

alibuild · 2024-03-19T16:47:43Z

Error while checking build/O2/fullCI for d33bb28 at 2024-03-19 17:47:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
task timeout reached .. killing all processes


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/d4209f5c7f643177006d0c6c024605161a99f18f/slc8_x86-64/o2checkcode/1.0-local246/etc/modulefiles
++ cat
--

Full log here.

alibuild · 2024-03-20T14:43:54Z

Error while checking build/O2/fullCI for 7dd01da at 2024-03-20 15:43:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/12889-slc8_x86-64/0/Detectors/ITSMFT/common/workflow/src/DeadMapBuilderSpec.cxx:338:11: error: 'alert' is not a member of 'fair::Severity'
/sw/SOURCES/O2/12889-slc8_x86-64/0/Detectors/ITSMFT/common/workflow/src/DeadMapBuilderSpec.cxx:338:11: error: 'alert' is not a member of 'fair::Severity'
/sw/SOURCES/O2/12889-slc8_x86-64/0/Detectors/ITSMFT/common/workflow/src/DeadMapBuilderSpec.cxx:338:11: error: 'alert' is not a member of 'fair::Severity'
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-03-20T21:27:07Z

Error while checking build/O2/fullCI for 907f5ec at 2024-03-28 23:25:

## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile itstpcMatch.log
./sim-challenge.logitstpcMatch.log-[15340:internal-dpl-ccdb-backend]: [22:25:45][ERROR] Failed to open file alien:///alice/data/CCDB/ITS/Config/AlpideParam/02/10715/76f24ad5-e339-11ec-9e90-200114580204?filetype=raw
./sim-challenge.logitstpcMatch.log-[15340:internal-dpl-ccdb-backend]: [22:25:45][FATAL] Unable to find object ITS/Config/AlpideParam/1546300800000
./sim-challenge.logitstpcMatch.log:[15340:internal-dpl-ccdb-backend]: [22:25:45][ERROR] Exception caught: Fatal error 
./sim-challenge.log[15340:internal-dpl-ccdb-backend]: [22:25:45][ERROR] Failed to open file alien:///alice/data/CCDB/ITS/Config/AlpideParam/02/10715/76f24ad5-e339-11ec-9e90-200114580204?filetype=raw
./sim-challenge.log[15340:internal-dpl-ccdb-backend]: [22:25:45][FATAL] Unable to find object ITS/Config/AlpideParam/1546300800000
./sim-challenge.log[15340:internal-dpl-ccdb-backend]: [22:25:45][ERROR] Exception caught: Fatal error 
./sim-challenge.log[15340:internal-dpl-ccdb-backend]: [22:25:45][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpcits-match-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 15340 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 15340 (exit 128)
./sim-challenge.log[INFO]    - First error: [22:25:45][FATAL] Unable to find object ITS/Config/AlpideParam/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (15340) had at least one message above severity 5: Unable to find object ITS/Config/AlpideParam/1546300800000
./midreco.log[14451:MIDRecoWriter]: [22:25:33][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[8098:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[8109:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[8114:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[8114:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[8114:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[8114:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[8114:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
[0 more errors; see full log]

Full log here.

shahor02 · 2024-03-20T22:04:33Z

@nicolovalle do I understand correctly that the info about "time-dependent dead chips" will be ignored if the distance between the queried orbit and best matching map "key" orbit > 30 s? I am asking because e.g. in the last entry of http://alice-ccdb.cern.ch/browse/ITS/Calib/TimeDeadMap I see gaps of ~600k orbits, i.e. > 50s.

nicolovalle · 2024-03-21T06:46:49Z

@nicolovalle do I understand correctly that the info about "time-dependent dead chips" will be ignored if the distance between the queried orbit and best matching map "key" orbit > 30 s? I am asking because e.g. in the last entry of http://alice-ccdb.cern.ch/browse/ITS/Calib/TimeDeadMap I see gaps of ~600k orbits, i.e. > 50s.

Hi @shahor02 , yes that’s all correct.
I can say that I checked the orbit gap for all the objects uploaded so far, that run -526641- and 545184 are the only ones with such a gap. All the others have at most few steps with gaps within 250k orbits… (which also are not optimal, in future runs we should have only 32k gap by construction).

I’m processing all the tfs in all the ctfs from a single EPN; those (few) fluctuations should really be in the TF distribution we had synchronously.

—-

P.s. could you please confirm that “LOG(important) << …” is the correct way to have an INFO message both in the logs on disk and in Infologger?

thanks.

nicolovalle · 2024-04-01T19:42:14Z

Hi @shahor02 , is there anything pending here? If not, can we merge it? (In particular, to have the infologger messages)
Thanks, cheers.

shahor02

sorry, missed your question: yes, LOG(important) will propagate to the IL since o2-itsmft-deadmap-builder-workflow is added to the topology with --infologger-severity important

…Group#12889) * ITS efficiency maps pretection for digitization out of range * ITS efficiency maps pretection for digitization out of range * ITS efficiency maps pretection for digitization out of range * typo in info message * sending message at EOR to infologger * fix formatting * fix * fix --------- Co-authored-by: Nicolo Valle <nicolo.valle@cern.ch>

nicolovalle added 3 commits March 19, 2024 13:29

ITS efficiency maps pretection for digitization out of range

56cc47b

ITS efficiency maps pretection for digitization out of range

ab90fe5

ITS efficiency maps pretection for digitization out of range

d33bb28

nicolovalle requested review from mconcas and shahor02 as code owners March 19, 2024 12:47

github-actions Bot added the mc label Mar 19, 2024

iravasen approved these changes Mar 19, 2024

View reviewed changes

nicolovalle added 3 commits March 20, 2024 15:08

typo in info message

5de44bd

sending message at EOR to infologger

2124158

fix formatting

7dd01da

nicolovalle added 2 commits March 20, 2024 16:30

fix

00e9c16

fix

907f5ec

nicolovalle changed the title ~~ITS efficiency maps pretection for digitization out of range~~ ITS efficiency maps protection for digitization out of range Mar 22, 2024

shahor02 approved these changes Apr 1, 2024

View reviewed changes

shahor02 merged commit fa06b8d into AliceO2Group:dev Apr 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ITS efficiency maps protection for digitization out of range#12889

ITS efficiency maps protection for digitization out of range#12889
shahor02 merged 8 commits into
AliceO2Group:devfrom
nicolovalle:nv-its-map-digitizer

nicolovalle commented Mar 19, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 19, 2024

Uh oh!

nicolovalle commented Mar 19, 2024

Uh oh!

alibuild commented Mar 19, 2024

Uh oh!

alibuild commented Mar 20, 2024

Uh oh!

alibuild commented Mar 20, 2024 •

edited

Loading

Uh oh!

shahor02 commented Mar 20, 2024

Uh oh!

nicolovalle commented Mar 21, 2024 •

edited

Loading

Uh oh!

nicolovalle commented Apr 1, 2024 •

edited

Loading

Uh oh!

shahor02 left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

nicolovalle commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 19, 2024

Uh oh!

nicolovalle commented Mar 19, 2024

Uh oh!

alibuild commented Mar 19, 2024

Uh oh!

alibuild commented Mar 20, 2024

Uh oh!

alibuild commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahor02 commented Mar 20, 2024

Uh oh!

nicolovalle commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolovalle commented Apr 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahor02 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

nicolovalle commented Mar 19, 2024 •

edited

Loading

alibuild commented Mar 20, 2024 •

edited

Loading

nicolovalle commented Mar 21, 2024 •

edited

Loading

nicolovalle commented Apr 1, 2024 •

edited

Loading