Skip to content

TPC: Add missing include#12461

Merged
shahor02 merged 1 commit into
AliceO2Group:devfrom
wiechula:SACs
Dec 16, 2023
Merged

TPC: Add missing include#12461
shahor02 merged 1 commit into
AliceO2Group:devfrom
wiechula:SACs

Conversation

@wiechula
Copy link
Copy Markdown
Collaborator

No description provided.

@wiechula wiechula requested a review from sawenzel as a code owner December 14, 2023 08:35

/// set directly the debug level
static void setStreamFlags(const StreamFlags streamFlags) { o2::conf::ConfigurableParam::setValue("DebugStreamerParam", "streamLevel", static_cast<int>(streamFlags)); }
static void setStreamFlags(const StreamFlags streamFlags) { o2::conf::ConfigurableParam::setValue<int>("DebugStreamerParam", "streamLevel", static_cast<int>(streamFlags)); }
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this is needed, for me it works as o2::conf::ConfigurableParam::setValue("DebugStreamerParam", "streamLevel",.. also, as well as o2::utils::ParameterDebugStreamer::Instance().setValue("streamLevel","7");

Exposing boost stuff in the header may lead to some problems.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Dec 14, 2023

Error while checking build/O2/fullCI for 8d3de1c at 2023-12-16 03:16:

## sw/BUILD/QualityControl-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc8_x86-64/O2/12461-slc8_x86-64-local1/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 1


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/a72c81fba08e434d0119c5962f6bd50115c98734/slc8_x86-64/o2checkcode/1.0-local296/etc/modulefiles
++ cat
--

Full log here.

#include "GPUCommonDef.h"
#if !defined(GPUCA_GPUCODE) && !defined(GPUCA_STANDALONE)
#include "CommonUtils/ConfigurableParamHelper.h"
#include <boost/property_tree/ptree.hpp>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... This is now needed in client code after #11825. Ideally, you would put it in source files.
But should be ok since it previously came directly via CommonUtils/ConfigurableParamHelper.h

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only wondering why it compiles everywhere? Do you have a special compiler?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sawenzel if you ask me, no, I am using what O2 provides, gcc (GCC) 12.2.0

@wiechula
Copy link
Copy Markdown
Collaborator Author

Hi @sawenzel , @shahor02 , this part of the code is complied conditionally if DEBUG_STREAMER is set, which is steered by

export ENABLE_DEBUG_STREAMER=1 

I always have this in my local builds, but it is obviously not on the build machines. And I assume you also don't have it.

@shahor02 shahor02 merged commit 7ffcf31 into AliceO2Group:dev Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants