Make sure Mergers always use Lifetime::Sporadic#12377
Conversation
f73421f to
9ecaddc
Compare
|
just one comment: we need to be a bit carefull here. If you expect lifetime data, it should not be marker as sporadic. This might be improved in the future, but right now, sporadic must not be used if inputs coming from different channels for the same tf are to be merged, as in that case only the input that arrives first is taken. Anyway, it applies only to consumeWhenAll completion policy, for consumeWhenAny it doesn't matter anyway. Not sure what the mergers use. |
|
Mergers is consumeWhenAny, so it does not wait for a complete slice. It cannot really count on it, since different QC tasks publish at different times and the timeslice id is the timestamp of the timer (AFAIK). So I assume we are safe here. |
No description provided.