Avoid exposing rANS internal details to ROOT#11892
Merged
Merged
Conversation
Member
Author
|
This is probably the quickest way to fix it. |
Collaborator
|
Yep, if this works sounds like the best solution to me.
Though I would still try to switch to something simpler than abseil, like robin hood, in any case.
|
Member
Author
|
@TimoWilken could you check how come the fullsystem test takes so long? |
Contributor
|
@ktf Uploading the logs failed because they weren't valid UTF-8 apparently. I've just fixed that in ali-bot and set the fullCI status manually for this PR. The o2-cs8 check is still running, but almost done. |
Contributor
|
Merged since all of the checks were green (except for the Intel Mac one, but that's a known problem and the compilation succeeded, at least). |
davidrohr
pushed a commit
that referenced
this pull request
Oct 10, 2023
leo-barreto
pushed a commit
to leo-barreto/AliceO2
that referenced
this pull request
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.