O2sim: Aggregating mode for mctracks proxy#11608
Merged
Merged
Conversation
sawenzel
previously approved these changes
Jul 4, 2023
Collaborator
sawenzel
left a comment
There was a problem hiding this comment.
Thanks for this development. Looks good to me. Maybe @DanielSamitz can also take a look?
ktf
reviewed
Jul 4, 2023
|
|
||
| DataProcessingHeader tdph{*TFcounter, 0}; | ||
| ConcreteDataMatcher tracksMatcher = DataSpecUtils::asConcreteDataMatcher(specs[1]); | ||
| tracksDH.dataOrigin = tracksMatcher.origin; |
Member
There was a problem hiding this comment.
nitpick: I would use the
DataHeader tracksDH {
.dataOrigin = ...,
.dataDescription = ...
};syntax.
Contributor
|
Thank you, this is great. In principle we are missing something similar in the o2sim-kine-publisher, but I'd say that there it is not so important, because there it is not necessary to do the conversion McTracks --> McParticles on the fly. |
Member
Author
|
@DanielSamitz there is I can update the kine-publisher as well, in a separate PR, if it is actually used. |
Collaborator
Collaborator
ktf
reviewed
Jul 6, 2023
sawenzel
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--aggregate-timeframe <number>option to combine<number>of incoming events into a single multipart message and require a Monitoring service so that TF counter can be sent and TF-based rate limiting works--aggregate-timeframe@sawenzel @mconcas