FT3: build v3b version of the geometry by default#11590
Merged
Conversation
mconcas
reviewed
Jun 30, 2023
Collaborator
|
Thanks @plariono , please find one single comment, you can merge the change from web if you want. |
Contributor
Author
|
ciao @mconcas, thank you for the fix. In fact the outer radius of 80 cm corresonds to the version v3b, so I changed also the naming. |
Collaborator
|
@plariono as soon as you fix the code formatting, we can have CI go through. |
Please consider the following formatting changes to AliceO2Group#11590
mconcas
approved these changes
Jul 4, 2023
Collaborator
Contributor
Author
|
Can this go in please @mconcas ? |
mconcas
approved these changes
Jul 10, 2023
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Aug 24, 2023
* Modifications of beampipe * Changes outer radius, correct version * Please consider the following formatting changes --------- Co-authored-by: Pavel Larionov <plariono@alicecerno2.cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to build the FT3 geometry of v3b version from the LOI. Currently it builds the v1.