O2sim: Add rate limiting to mctracks proxy#11578
Merged
sawenzel merged 5 commits intoJun 29, 2023
Merged
Conversation
sawenzel
reviewed
Jun 28, 2023
| parts.AddPart(std::move(payload)); | ||
| forwardchannel.Send(parts); | ||
| LOGP(info, "SENDING END-OF-STREAM TO PROXY AT {}", address.c_str()); | ||
| } |
Collaborator
There was a problem hiding this comment.
couldn't we have this in the HitMerger (which also knows when all
events are done)? Or do you target EOS even in case of failures here?
Member
Author
There was a problem hiding this comment.
Indeed, this way it will be sent even in case of failures so the proxy will not be stuck if o2sim was killed. We can also potentially avoid event counting in the proxy, but I did not touch that for now.
sawenzel
approved these changes
Jun 29, 2023
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Aug 24, 2023
* O2sim: rate-limited proxy * change channel to pair from pub/sub to prevent dropping events * add rate limit to example script * send EoS to proxy if we finish early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rate limiting to mctracks-proxy. Adds sending EoS to forwarding channel if o2sim quits earlier. Kine forward channel configuration is changed to
pairto avoid dropping events. Note that proxy sends a single event per "timeframe". Rate limiting needs to be set in terms of number of events that are to be kept in memory by the proxy.