CCDBDownloader: More error checks - #11489
Merged
Merged
Conversation
TrifleMichael
requested review from
a team,
Barthelemy,
costing and
sawenzel
as code owners
June 13, 2023 11:23
Contributor
Author
|
I've added 4 types of error checks: Libuv, CurlMulti, CurlEasy and Sockets. There is an additional check for whether the uvloop closes prematurely. That check uses the mIsClosing variable. Because sockets are opened in only one line, and closed in two lines I didn't create a seperate function for testing them. Additionaly not creating that function makes it easier to differentiate whether closing or opening failed. I've tested to make sure that no errors are logged on the current version. If an error causes a segmentation fault the thread will crash without calling LOG(error). |
Collaborator
|
Error while checking build/O2/fullCI for ad5f7ee at 2023-06-15 18:40: Full log here. |
Collaborator
|
Could you rebase without merge commits, and squash the fixup commits? |
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Aug 24, 2023
* CCDBDownloader: Libuv error checks * Formatting correction * Added check for premature uvloop closure * Added curl checks and socket open/close checks * After merge fix * Removing redundant download
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added result check for all libuv functions that return an error code. Libuv functions that lack this check are the ones returning void.
Even though almost all libuv function errors result in segmentation faults, this change may help with debugging the downloader in the future.