Skip to content

Drop need for libuv#10954

Merged
davidrohr merged 2 commits into
AliceO2Group:devfrom
ktf:ccdb-downloader-fixes
Mar 15, 2023
Merged

Drop need for libuv#10954
davidrohr merged 2 commits into
AliceO2Group:devfrom
ktf:ccdb-downloader-fixes

Conversation

@ktf

@ktf ktf commented Mar 15, 2023

Copy link
Copy Markdown
Member

No description provided.

@ktf ktf requested review from a team, Barthelemy, costing and sawenzel as code owners March 15, 2023 01:10
@ktf

ktf commented Mar 15, 2023

Copy link
Copy Markdown
Member Author

@davidrohr @shahor02 this should eliminate the need to expose libuv to root.
@costing @sawenzel there is quite a few places where I am not actually sure CCDBDownloader is not leaking memory. Maybe the code should be further reviewed before it enters production.

@alibuild

alibuild commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for a03e219 at 2023-03-15 03:45:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/10954-slc8_x86-64/0/CCDB/test/testCcdbApiDownloader.cxx:283:13: error: aggregate 'uv_loop_t loop' has incomplete type and cannot be defined
ninja: build stopped: subcommand failed.

Full log here.

@davidrohr

davidrohr commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

ok, testing this on the EPNs.
Also fixed the compilation of the tests

davidrohr
davidrohr approved these changes Mar 15, 2023
View reviewed changes

@davidrohr davidrohr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the fix works

@alibuild

alibuild commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for 5fb30da at 2023-03-15 13:22:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
/sw/SOURCES/O2/10954-slc8_x86-64/0//CCDB/include/CCDB/CCDBDownloader.h:1:1: error: missing or malformed copyright notice
/sw/SOURCES/O2/10954-slc8_x86-64/0//CCDB/src/CCDBDownloader.cxx:1:1: error: missing or malformed copyright notice
/sw/SOURCES/O2/10954-slc8_x86-64/0//Framework/Core/include/Framework/DeviceStateEnums.h:1:1: error: missing or malformed copyright notice
--

Full log here.

@davidrohr davidrohr merged commit d8c3eb4 into AliceO2Group:dev Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr davidrohr approved these changes

@costing costing Awaiting requested review from costing costing is a code owner

@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktf @alibuild @davidrohr