DPL: avoid crash on nullptr in proxy - #10077
Merged
Merged
Conversation
In principle I do not expect this to happen, but just in case.
Member
Author
|
@dennisklein @rbx is there any case in which a fairmq::Parts would contain a unique ptr set to nullptr? |
Contributor
|
You will not have We also check for So the check is not wrong. |
Collaborator
|
this doesn't fix the crash we are seeing (tested in environment id 2b8Hxbczvnd) |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In principle I do not expect this to happen, but just in case.