Skip to content

Sync #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TommyLemon merged 14 commits into from
Oct 12, 2019
Merged

Sync #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c32aa1d
fix expr determination way; remove an unnessary limit(); add 7 test c…
zhangchunlin Oct 11, 2019
dda827b
update some comment; fix "NameError: name 'model_name' is not defined…
zhangchunlin Oct 11, 2019
f0c5026
add 1 test case, now 55 test cases for apijson-get
zhangchunlin Oct 11, 2019
d2ab647
fix "AttributeError: 'Request' object has no attribute 'user'"; add 4…
zhangchunlin Oct 11, 2019
9461f44
fix "AttributeError: 'Request' object has no attribute 'user'"; add 1…
zhangchunlin Oct 11, 2019
b27ad9b
add 4 test cases for apijson-head, now 9 cases
zhangchunlin Oct 11, 2019
99812cf
fix @role support in apijson-put; add 7 test cases
zhangchunlin Oct 12, 2019
c19ebae
doc: add difference in tag parameter in apijson post/put
zhangchunlin Oct 12, 2019
425d3f8
apijson-table: fix apijson-put @role not work problem; demo: make use…
zhangchunlin Oct 12, 2019
65d9b84
apijson-table: fix apijson-post with @role
zhangchunlin Oct 12, 2019
ffdca01
apijson-table: fix @role in apijson-delete
zhangchunlin Oct 12, 2019
fbd0249
apijson-viewedit: fix @role
zhangchunlin Oct 12, 2019
66d6d27
apijson-table: fix key and title problem in viewedit_items
zhangchunlin Oct 12, 2019
cbee292
test: workaround date string convert case cause by pendulum bug: htt…
zhangchunlin Oct 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add 4 test cases for apijson-head, now 9 cases
  • Loading branch information
@zhangchunlin
zhangchunlin committed Oct 11, 2019
commit b27ad9bb0e7794a9716642196bd930b4f90b9d7d
46 changes: 46 additions & 0 deletions tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,4 +875,50 @@ def test_apijson_head():
>>> d = json_loads(r.data)
>>> print(d)
{'code': 400, 'msg': "role 'UNKNOWN' not have permission HEAD for 'privacy'"}

>>> #apijson head, user don't have role
>>> data ='''{
... "privacy": {
... "@role":"ADMIN",
... "id": 1
... }
... }'''
>>> r = handler.post('/apijson/head', data=data, pre_call=pre_call_as("usera"), middlewares=[])
>>> d = json_loads(r.data)
>>> print(d)
{'code': 400, 'msg': "user doesn't have role 'ADMIN'"}

>>> #apijson head, with OWNER
>>> data ='''{
... "moment": {
... "@role":"OWNER"
... }
... }'''
>>> r = handler.post('/apijson/head', data=data, pre_call=pre_call_as("usera"), middlewares=[])
Moment: owner_condition
>>> d = json_loads(r.data)
>>> print(d)
{'code': 200, 'msg': 'success', 'moment': {'code': 200, 'msg': 'success', 'count': 1}}

>>> #apijson head, with OWNER but cannot filter with OWNER
>>> data ='''{
... "publicnotice": {
... "@role":"OWNER"
... }
... }'''
>>> r = handler.post('/apijson/head', data=data, pre_call=pre_call_as("usera"), middlewares=[])
>>> d = json_loads(r.data)
>>> print(d)
{'code': 400, 'msg': "'publicnotice' cannot filter with owner"}

>>> #apijson head, with a nonexistant column
>>> data ='''{
... "moment": {
... "nonexist": 2
... }
... }'''
>>> r = handler.post('/apijson/head', data=data, pre_call=pre_call_as("admin"), middlewares=[])
>>> d = json_loads(r.data)
>>> print(d)
{'code': 400, 'msg': "'moment' don't have field 'nonexist'"}
"""
1 change: 1 addition & 0 deletions uliweb_apijson/apijson/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ def _head(self,key):
permission_check_ok = True
else:
return json({"code":400,"msg":"user doesn't have role '%s'"%(params_role)})
#current implementation won't run here, but keep for safe
if not permission_check_ok:
return json({"code":400,"msg":"no permission"})

Expand Down