This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Fixed XXE Vulnerability when parsing 'nmap_data'#1
Merged
Conversation
|
Congratulations @mufeedvh - you are the successful huntr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard XML library is vulnerable to XXE (XML External Entity) attacks such as "Billion Laughs" XXE bomb attack. This issue has been raised on Feb 2018 (savon-noir#87) and haven't been mitigated because there were no good solutions for this vulnerability.
Although there has been discussions of these vulnerabilities in Python's official bug tracker (https://bugs.python.org/issue17239) which helped me come up with a solution that is to use 'defusedxml' instead of the standard 'xml' module which is a XML bomb protection for Python stdlib modules.
Fixed! 👍