[Docs] Update examples to favour functional _document#39871
Merged
kodiakhq[bot] merged 2 commits intovercel:canaryfrom Aug 23, 2022
Merged
[Docs] Update examples to favour functional _document#39871kodiakhq[bot] merged 2 commits intovercel:canaryfrom
kodiakhq[bot] merged 2 commits intovercel:canaryfrom
Conversation
44960c4 to
6a61347
Compare
This was referenced Sep 8, 2022
balazsorban44
added a commit
that referenced
this pull request
Sep 9, 2022
Closes #40366 Rebass is not dependent on `styled-components` anymore. See: https://rebassjs.org/migrating/#v4-breaking-changes Closes #40367 Document has been converted (#39871) from class, so `this.props` threw an error. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
_documents to functional documents_document.jswhere defaultMyDocument.getInitialPropswhere defaultMotivation
This removes some boilerplate and prepares examples for server components.
Documentation / Examples
pnpm lint