Skip to content

feat: expose timeStorageClassUpdated property of blob's#456

Merged
frankyn merged 4 commits intogoogleapis:masterfrom
athakor:storage-blob-timeStorageClassUpdated
Sep 3, 2020
Merged

feat: expose timeStorageClassUpdated property of blob's#456
frankyn merged 4 commits intogoogleapis:masterfrom
athakor:storage-blob-timeStorageClassUpdated

Conversation

@athakor
Copy link
Copy Markdown
Contributor

@athakor athakor commented Aug 6, 2020 •
edited
Loading

Fixes #455

@athakor athakor requested a review from frankyn August 6, 2020 17:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 6, 2020 •
edited
Loading

Codecov Report

Merging #456 into master will increase coverage by 0.10%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #456      +/-   ##
============================================
+ Coverage     64.59%   64.69%   +0.10%     
+ Complexity      626      620       -6     
============================================
  Files            32       32              
  Lines          5236     5249      +13     
  Branches        507      510       +3     
============================================
+ Hits           3382     3396      +14     
+ Misses         1695     1694       -1     
  Partials        159      159
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/storage/BlobInfo.java 88.34% <90.00%> (+0.04%) 94.00 <1.00> (+3.00)
...e/src/main/java/com/google/cloud/storage/Blob.java 83.70% <100.00%> (+1.32%) 30.00 <0.00> (ø)
...rc/main/java/com/google/cloud/storage/Storage.java 80.83% <100.00%> (+0.04%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db358c8...1d4a75b. Read the comment docs.

@athakor athakor changed the title feat: expose timeStorageClassUpdated properties of blob's feat: expose timeStorageClassUpdated property of blob's Aug 6, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Aug 21, 2020
frankyn
frankyn suggested changes Sep 1, 2020
View reviewed changes
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java Outdated
/** Sets the blob's storage class. */
public abstract Builder setStorageClass(StorageClass storageClass);

abstract Builder setTimeStorageClassUpdated(Long timeStorageClassUpdated);
Copy link
Copy Markdown
Contributor

@frankyn frankyn Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the same pattern in custom time to raise an exception and implement this method to prevent breaking changes.

Copy link
Copy Markdown
Contributor Author

@athakor athakor Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@athakor athakor force-pushed the storage-blob-timeStorageClassUpdated branch from 6b72409 to 8381b00 Compare September 2, 2020 08:34
@athakor
Copy link
Copy Markdown
Contributor Author

athakor commented Sep 2, 2020

@frankyn PTAL

@frankyn frankyn merged commit 57853ec into googleapis:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose timeStorageClassUpdated property of the blob's

2 participants

@athakor @frankyn