Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Commit ed46c97

Browse files
yoshi-automationyoshi-automation
authored
feat: add order field to TagField and TagTemplateField message in tags.proto (#166)
fix: broken document links & polish comments feat: add csharp/ruby/PHP namespaces chore: update copyright for proto files PiperOrigin-RevId: 307068250 Source-Author: Google APIs <noreply@google.com> Source-Date: Fri Apr 17 10:26:08 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: b5e9b0b09cc15c263f07da92fa64db31b2e4dd07 Source-Link: googleapis/googleapis@b5e9b0b
1 parent 7d5dd43 commit ed46c97

51 files changed

Lines changed: 1206 additions & 987 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎google-cloud-datacatalog/src/main/java/com/google/cloud/datacatalog/v1beta1/DataCatalogClient.java‎

Lines changed: 110 additions & 120 deletions
Large diffs are not rendered by default.

‎google-cloud-datacatalog/src/test/java/com/google/cloud/datacatalog/v1beta1/DataCatalogClientTest.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -905,11 +905,13 @@ public void createTagTemplateFieldTest() {
905905
String name = "name3373707";
906906
String displayName = "displayName1615086568";
907907
boolean isRequired = true;
908+
int order = 106006350;
908909
TagTemplateField expectedResponse =
909910
TagTemplateField.newBuilder()
910911
.setName(name)
911912
.setDisplayName(displayName)
912913
.setIsRequired(isRequired)
914+
.setOrder(order)
913915
.build();
914916
mockDataCatalog.addResponse(expectedResponse);
915917

@@ -961,11 +963,13 @@ public void updateTagTemplateFieldTest() {
961963
String name2 = "name2-1052831874";
962964
String displayName = "displayName1615086568";
963965
boolean isRequired = true;
966+
int order = 106006350;
964967
TagTemplateField expectedResponse =
965968
TagTemplateField.newBuilder()
966969
.setName(name2)
967970
.setDisplayName(displayName)
968971
.setIsRequired(isRequired)
972+
.setOrder(order)
969973
.build();
970974
mockDataCatalog.addResponse(expectedResponse);
971975

@@ -1017,11 +1021,13 @@ public void renameTagTemplateFieldTest() {
10171021
String name2 = "name2-1052831874";
10181022
String displayName = "displayName1615086568";
10191023
boolean isRequired = true;
1024+
int order = 106006350;
10201025
TagTemplateField expectedResponse =
10211026
TagTemplateField.newBuilder()
10221027
.setName(name2)
10231028
.setDisplayName(displayName)
10241029
.setIsRequired(isRequired)
1030+
.setOrder(order)
10251031
.build();
10261032
mockDataCatalog.addResponse(expectedResponse);
10271033

‎grpc-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/DataCatalogGrpc.java‎

Lines changed: 156 additions & 152 deletions
Large diffs are not rendered by default.

‎proto-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/Common.java‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,13 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
3939
+ "n.proto\022 google.cloud.datacatalog.v1beta"
4040
+ "1*U\n\020IntegratedSystem\022!\n\035INTEGRATED_SYST"
4141
+ "EM_UNSPECIFIED\020\000\022\014\n\010BIGQUERY\020\001\022\020\n\014CLOUD_"
42-
+ "PUBSUB\020\002Bx\n$com.google.cloud.datacatalog"
43-
+ ".v1beta1P\001ZKgoogle.golang.org/genproto/g"
44-
+ "oogleapis/cloud/datacatalog/v1beta1;data"
45-
+ "catalog\370\001\001b\006proto3"
42+
+ "PUBSUB\020\002B\344\001\n$com.google.cloud.datacatalo"
43+
+ "g.v1beta1P\001ZKgoogle.golang.org/genproto/"
44+
+ "googleapis/cloud/datacatalog/v1beta1;dat"
45+
+ "acatalog\370\001\001\252\002 Google.Cloud.DataCatalog.V"
46+
+ "1Beta1\312\002 Google\\Cloud\\DataCatalog\\V1beta"
47+
+ "1\352\002#Google::Cloud::DataCatalog::V1beta1b"
48+
+ "\006proto3"
4649
};
4750
descriptor =
4851
com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(

‎proto-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagRequest.java‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
134134
*
135135
*
136136
* <pre>
137-
* Required. The name of the resource to attach this tag to. Tags can be
138-
* attached to Entries. Example:
137+
* Required. The name of the resource to attach this tag to. Tags can be attached to
138+
* Entries. Example:
139139
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
140140
* Note that this Tag and its child resources may not actually be stored in
141141
* the location in this name.
@@ -162,8 +162,8 @@ public java.lang.String getParent() {
162162
*
163163
*
164164
* <pre>
165-
* Required. The name of the resource to attach this tag to. Tags can be
166-
* attached to Entries. Example:
165+
* Required. The name of the resource to attach this tag to. Tags can be attached to
166+
* Entries. Example:
167167
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
168168
* Note that this Tag and its child resources may not actually be stored in
169169
* the location in this name.
@@ -586,8 +586,8 @@ public Builder mergeFrom(
586586
*
587587
*
588588
* <pre>
589-
* Required. The name of the resource to attach this tag to. Tags can be
590-
* attached to Entries. Example:
589+
* Required. The name of the resource to attach this tag to. Tags can be attached to
590+
* Entries. Example:
591591
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
592592
* Note that this Tag and its child resources may not actually be stored in
593593
* the location in this name.
@@ -614,8 +614,8 @@ public java.lang.String getParent() {
614614
*
615615
*
616616
* <pre>
617-
* Required. The name of the resource to attach this tag to. Tags can be
618-
* attached to Entries. Example:
617+
* Required. The name of the resource to attach this tag to. Tags can be attached to
618+
* Entries. Example:
619619
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
620620
* Note that this Tag and its child resources may not actually be stored in
621621
* the location in this name.
@@ -642,8 +642,8 @@ public com.google.protobuf.ByteString getParentBytes() {
642642
*
643643
*
644644
* <pre>
645-
* Required. The name of the resource to attach this tag to. Tags can be
646-
* attached to Entries. Example:
645+
* Required. The name of the resource to attach this tag to. Tags can be attached to
646+
* Entries. Example:
647647
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
648648
* Note that this Tag and its child resources may not actually be stored in
649649
* the location in this name.
@@ -669,8 +669,8 @@ public Builder setParent(java.lang.String value) {
669669
*
670670
*
671671
* <pre>
672-
* Required. The name of the resource to attach this tag to. Tags can be
673-
* attached to Entries. Example:
672+
* Required. The name of the resource to attach this tag to. Tags can be attached to
673+
* Entries. Example:
674674
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
675675
* Note that this Tag and its child resources may not actually be stored in
676676
* the location in this name.
@@ -692,8 +692,8 @@ public Builder clearParent() {
692692
*
693693
*
694694
* <pre>
695-
* Required. The name of the resource to attach this tag to. Tags can be
696-
* attached to Entries. Example:
695+
* Required. The name of the resource to attach this tag to. Tags can be attached to
696+
* Entries. Example:
697697
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
698698
* Note that this Tag and its child resources may not actually be stored in
699699
* the location in this name.

‎proto-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagRequestOrBuilder.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ public interface CreateTagRequestOrBuilder
2727
*
2828
*
2929
* <pre>
30-
* Required. The name of the resource to attach this tag to. Tags can be
31-
* attached to Entries. Example:
30+
* Required. The name of the resource to attach this tag to. Tags can be attached to
31+
* Entries. Example:
3232
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
3333
* Note that this Tag and its child resources may not actually be stored in
3434
* the location in this name.
@@ -45,8 +45,8 @@ public interface CreateTagRequestOrBuilder
4545
*
4646
*
4747
* <pre>
48-
* Required. The name of the resource to attach this tag to. Tags can be
49-
* attached to Entries. Example:
48+
* Required. The name of the resource to attach this tag to. Tags can be attached to
49+
* Entries. Example:
5050
* * projects/{project_id}/locations/{location}/entryGroups/{entry_group_id}/entries/{entry_id}
5151
* Note that this Tag and its child resources may not actually be stored in
5252
* the location in this name.

‎proto-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateFieldRequest.java‎

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,7 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
144144
*
145145
* <pre>
146146
* Required. The name of the project and the template location
147-
* [region](/compute/docs/regions-zones/#available).
148-
* NOTE: Currently, only the `us-central1 region` is supported.
147+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
149148
* Example:
150149
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
151150
* </pre>
@@ -172,8 +171,7 @@ public java.lang.String getParent() {
172171
*
173172
* <pre>
174173
* Required. The name of the project and the template location
175-
* [region](/compute/docs/regions-zones/#available).
176-
* NOTE: Currently, only the `us-central1 region` is supported.
174+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
177175
* Example:
178176
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
179177
* </pre>
@@ -681,8 +679,7 @@ public Builder mergeFrom(
681679
*
682680
* <pre>
683681
* Required. The name of the project and the template location
684-
* [region](/compute/docs/regions-zones/#available).
685-
* NOTE: Currently, only the `us-central1 region` is supported.
682+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
686683
* Example:
687684
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
688685
* </pre>
@@ -709,8 +706,7 @@ public java.lang.String getParent() {
709706
*
710707
* <pre>
711708
* Required. The name of the project and the template location
712-
* [region](/compute/docs/regions-zones/#available).
713-
* NOTE: Currently, only the `us-central1 region` is supported.
709+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
714710
* Example:
715711
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
716712
* </pre>
@@ -737,8 +733,7 @@ public com.google.protobuf.ByteString getParentBytes() {
737733
*
738734
* <pre>
739735
* Required. The name of the project and the template location
740-
* [region](/compute/docs/regions-zones/#available).
741-
* NOTE: Currently, only the `us-central1 region` is supported.
736+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
742737
* Example:
743738
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
744739
* </pre>
@@ -764,8 +759,7 @@ public Builder setParent(java.lang.String value) {
764759
*
765760
* <pre>
766761
* Required. The name of the project and the template location
767-
* [region](/compute/docs/regions-zones/#available).
768-
* NOTE: Currently, only the `us-central1 region` is supported.
762+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
769763
* Example:
770764
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
771765
* </pre>
@@ -787,8 +781,7 @@ public Builder clearParent() {
787781
*
788782
* <pre>
789783
* Required. The name of the project and the template location
790-
* [region](/compute/docs/regions-zones/#available).
791-
* NOTE: Currently, only the `us-central1 region` is supported.
784+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
792785
* Example:
793786
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
794787
* </pre>

‎proto-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateFieldRequestOrBuilder.java‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ public interface CreateTagTemplateFieldRequestOrBuilder
2828
*
2929
* <pre>
3030
* Required. The name of the project and the template location
31-
* [region](/compute/docs/regions-zones/#available).
32-
* NOTE: Currently, only the `us-central1 region` is supported.
31+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
3332
* Example:
3433
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
3534
* </pre>
@@ -46,8 +45,7 @@ public interface CreateTagTemplateFieldRequestOrBuilder
4645
*
4746
* <pre>
4847
* Required. The name of the project and the template location
49-
* [region](/compute/docs/regions-zones/#available).
50-
* NOTE: Currently, only the `us-central1 region` is supported.
48+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions).
5149
* Example:
5250
* * projects/{project_id}/locations/us-central1/tagTemplates/{tag_template_id}
5351
* </pre>

‎proto-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateRequest.java‎

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,7 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
143143
*
144144
* <pre>
145145
* Required. The name of the project and the template location
146-
* [region](/compute/docs/regions-zones/#available).
147-
* NOTE: Currently, only the `us-central1 region` is supported.
146+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
148147
* Example:
149148
* * projects/{project_id}/locations/us-central1
150149
* </pre>
@@ -171,8 +170,7 @@ public java.lang.String getParent() {
171170
*
172171
* <pre>
173172
* Required. The name of the project and the template location
174-
* [region](/compute/docs/regions-zones/#available).
175-
* NOTE: Currently, only the `us-central1 region` is supported.
173+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
176174
* Example:
177175
* * projects/{project_id}/locations/us-central1
178176
* </pre>
@@ -666,8 +664,7 @@ public Builder mergeFrom(
666664
*
667665
* <pre>
668666
* Required. The name of the project and the template location
669-
* [region](/compute/docs/regions-zones/#available).
670-
* NOTE: Currently, only the `us-central1 region` is supported.
667+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
671668
* Example:
672669
* * projects/{project_id}/locations/us-central1
673670
* </pre>
@@ -694,8 +691,7 @@ public java.lang.String getParent() {
694691
*
695692
* <pre>
696693
* Required. The name of the project and the template location
697-
* [region](/compute/docs/regions-zones/#available).
698-
* NOTE: Currently, only the `us-central1 region` is supported.
694+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
699695
* Example:
700696
* * projects/{project_id}/locations/us-central1
701697
* </pre>
@@ -722,8 +718,7 @@ public com.google.protobuf.ByteString getParentBytes() {
722718
*
723719
* <pre>
724720
* Required. The name of the project and the template location
725-
* [region](/compute/docs/regions-zones/#available).
726-
* NOTE: Currently, only the `us-central1 region` is supported.
721+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
727722
* Example:
728723
* * projects/{project_id}/locations/us-central1
729724
* </pre>
@@ -749,8 +744,7 @@ public Builder setParent(java.lang.String value) {
749744
*
750745
* <pre>
751746
* Required. The name of the project and the template location
752-
* [region](/compute/docs/regions-zones/#available).
753-
* NOTE: Currently, only the `us-central1 region` is supported.
747+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
754748
* Example:
755749
* * projects/{project_id}/locations/us-central1
756750
* </pre>
@@ -772,8 +766,7 @@ public Builder clearParent() {
772766
*
773767
* <pre>
774768
* Required. The name of the project and the template location
775-
* [region](/compute/docs/regions-zones/#available).
776-
* NOTE: Currently, only the `us-central1 region` is supported.
769+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
777770
* Example:
778771
* * projects/{project_id}/locations/us-central1
779772
* </pre>

‎proto-google-cloud-datacatalog-v1beta1/src/main/java/com/google/cloud/datacatalog/v1beta1/CreateTagTemplateRequestOrBuilder.java‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ public interface CreateTagTemplateRequestOrBuilder
2828
*
2929
* <pre>
3030
* Required. The name of the project and the template location
31-
* [region](/compute/docs/regions-zones/#available).
32-
* NOTE: Currently, only the `us-central1 region` is supported.
31+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
3332
* Example:
3433
* * projects/{project_id}/locations/us-central1
3534
* </pre>
@@ -46,8 +45,7 @@ public interface CreateTagTemplateRequestOrBuilder
4645
*
4746
* <pre>
4847
* Required. The name of the project and the template location
49-
* [region](/compute/docs/regions-zones/#available).
50-
* NOTE: Currently, only the `us-central1 region` is supported.
48+
* [region](https://cloud.google.com/data-catalog/docs/concepts/regions.
5149
* Example:
5250
* * projects/{project_id}/locations/us-central1
5351
* </pre>

0 commit comments

Comments
 (0)