fix: [gax-java] Add speedy Bazel builds to Travis#1181
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1181 +/- ##
=========================================
Coverage 78.98% 78.98%
Complexity 1194 1194
=========================================
Files 205 205
Lines 5259 5259
Branches 435 435
=========================================
Hits 4154 4154
Misses 933 933
Partials 172 172 Continue to review full report at Codecov.
|
vam-google
left a comment
There was a problem hiding this comment.
Thanks for doing it! Can we do it as a separate task? Now gradle and bazel go together as a part of the same build, while it would be cleaner if they were two different jobs (this is how ti is done for gapic-generator, for example).
Apart from that, it is simply awesome! Adding bazel build in CI was a long lasting "pending" task that nobody has actually ever done. As you noticed (given the other PR with a fix), the absence of it could cause bazel build for gax to fail even when gradlew one was fine.
|
No problem. Done, split them into separate tasks. |
vam-google
left a comment
There was a problem hiding this comment.
LGTM. Just an optional minor comment, feel free to ignore.
No description provided.