This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
=========================================
Coverage 78.98% 78.98%
Complexity 1194 1194
=========================================
Files 205 205
Lines 5259 5259
Branches 435 435
=========================================
Hits 4154 4154
Misses 933 933
Partials 172 172 Continue to review full report at Codecov.
|
vam-google
approved these changes
Sep 14, 2020
Contributor
vam-google
left a comment
There was a problem hiding this comment.
LGTM, though bazel_skylib version info should probably stay in bazel files directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.