fix(android): prevent clipped font icons on Android#10858
Merged
Conversation
Add a 1px padding on each edge when creating the bitmap, this guarantees enough space for fractional/anti-aliased edges across all DPIs and devices.
|
View your CI Pipeline Execution ↗ for commit 3393c5c
☁️ Nx Cloud last updated this comment at |
NathanWalker
approved these changes
Sep 25, 2025
NathanWalker
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a 1px padding on each edge when creating the bitmap, this guarantees enough space for fractional/anti-aliased edges across all DPIs and devices.
PR Checklist
What is the current behavior?
Right now, font icons used in Image or ActionItem etc (font://...) mitght get clipped on the top and right on certain devices/dpis, 1px is missing on top and right.
This is because NativeScript currently uses:
getTextBoundsreturns an integer rectangle, rounded down.The actual glyph rasterization may extend slightly beyond this box due to fractional scaling and anti-aliasing.
What is the new behavior?
1px padding is added on each edge when creating the bitmap:
This guarantees enough space for fractional/anti-aliased edges across all DPIs and devices.
Fixes/Implements/Closes #10857 .