gh-138050: [WIP] JIT - Streamline MAKE_WARM - move coldness check to executor creation #138240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAKE_WARMmicro-op #138050Hey @markshannon!
I am not sure if this is what you meant by "perhaps in the jit itself", however it made sense to me to cleanup when more executors are created - so that we can keep the amount of executors reasonable.
Also - I'm unsure if this is the best point to perform the check during this process.
I had another idea of moving the check to
ENTER_EXECUTOR, which is less frequent thanMAKE_WARM- would that be a better point to perform the check?