gh-134891: Add PyUnstable_Unicode_GET_CACHED_HASH #134892
Draft
+55
鈭�5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
May 29, 2025
Include/cpython/unicodeobject.h
Outdated
Comment on lines
305
to
307
| PyUnstable_Unicode_GET_CACHED_HASH(PyObject *op) { | ||
| return _PyASCIIObject_CAST(op)->hash; | ||
| } |
There was a problem hiding this comment.
Hash can be computed and assigned concurrently so to avoid a data race in free-threaded build:
#ifdef Py_GIL_DISABLED
return _Py_atomic_load_ssize_relaxed(&_PyASCIIObject_CAST(op)->hash);
#else
return _PyASCIIObject_CAST(op)->hash;
#endif
For example, in unicodeobject.c:
cpython/Objects/unicodeobject.c
Lines 170 to 175 in d963436
colesbury
reviewed
May 29, 2025
Modules/_testcapi/unicode.c
Outdated
| static PyObject* | ||
| unicode_GET_CACHED_HASH(PyObject *self, PyObject *arg) | ||
| { | ||
| return PyLong_FromLong((long)PyUnstable_Unicode_GET_CACHED_HASH(arg)); |
There was a problem hiding this comment.
Use PyLong_FromSSize_t. Py_hash_t is an alias for Py_ssize_t, but it might be a different size than long.
cmarqu
reviewed
May 29, 2025
Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyUnstable_Unicode_GET_CACHED_HASH聽#134891馃摎 Documentation preview 馃摎: https://cpython-previews--134892.org.readthedocs.build/