gh-110105: Fix MSVC ARM64 atomic add of 16 and 8-bit values #110116
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC versions starting with 19.33 (and fixed in 19.37) do not properly sign extend the value read from the atomic pointer in `_InterlockedExchangeAdd8` and `_InterlockedExchangeAdd16`. Work around this issue by using a compare-exchange loop for all MSVC versions prior to 19.37 on ARM64.
|
@zooba are you able to test this on your private ARM64 buildbot? I did some minimal testing by making sure the new code paths work on Windows x64, but I don't have access to a Windows arm64 machine. GHA unfortunately doesn't have Windows arm64 runners. |
|
!buildbot ARM |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 3f8c15d 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
I strongly suspect it's going to be all the operations, not just add. Because the test crashes we never find out which other ones fail (it would be better to return an exit code than to And I'm afraid I won't have a chance to run tests until Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC versions starting with 19.33 (and fixed in 19.37) do not properly sign extend the value read from the atomic pointer in
_InterlockedExchangeAdd8and_InterlockedExchangeAdd16. Work around this issue by using a compare-exchange loop for all MSVC versions prior to 19.37 on ARM64.