Adapt to sourceLocationPrefix change in qltest#17536
Merged
hvitved merged 5 commits intogithub:mainfrom Oct 4, 2024
Merged
Conversation
8b4a142 to
074bea4
Compare
1968a50 to
bce4d35
Compare
bce4d35 to
5416983
Compare
5416983 to
1ae0049
Compare
1ae0049 to
4e7fc0c
Compare
4e7fc0c to
3880a89
Compare
Contributor
Author
|
Rebased to resolve sub module merge conflict on internal PR. |
ccc939f
3880a89 to
ccc939f
Compare
Contributor
Author
|
Rebased again, and updated some JS expected test output. |
Contributor
|
JS 👍 once the tests pass |
ccc939f to
d0ca39f
Compare
MathiasVP
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
sourceLocationPrefixfor databases created withcodeql test runwould be the path of the enclosing qlpack, which makes little sense. This PR adapts our QL code to changingsourceLocationPrefixto be the actual path of the test, similar to what would happen if one rancodeql database createon the test folder.