Update tkinter.Misc for 3.13
#12367
Merged
Update tkinter.Misc for 3.13
#12367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
commented
Jul 20, 2024
|
CC: @Akuli |
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Jul 21, 2024
| # Supports options from `_BusyInfo`` | ||
| def tk_busy_cget(self, option: Literal["cursor"]) -> _Cursor: ... | ||
| busy_cget = tk_busy_cget | ||
| def tk_busy_configure(self, cnf: Any = None, **kw: Any) -> Any: ... |
There was a problem hiding this comment.
You can overload this similarly to other configure methods to get rid of **kw: Any. Look at Tk.configure for a relatively simple example.
After writing the types for those other configure methods, I have realized that there are better ways to do it, but that's beyond the scope of this PR and it's fine to go with the existing pattern. By far the most common use case is passing keyword arguments and ignoring the return value, e.g. widget.busy_config(cursor="hand2") in this case.
Co-authored-by: Akuli <akuviljanen17@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new methods on
tkinter.Miscfor 3.13.