Swift: switch to shared, parameterized CFG library #15219
+467
−1,224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift/ql/lib/codeql/swift/controlflow/internal/ControlFlowGraphParameter.qll
Fixed
Show fixed
Hide fixed
geoffw0
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Looks good, but there are some odds and ends to finish:
- needs a change note and autoformat.
- fix for the
CfgConsistencytests (it looks like they're trying toimportan old file). - plus see my two comments
abovebelow. - then a DCA run to check for regressions / build confidence.
swift/ql/lib/codeql/swift/controlflow/internal/ControlFlowGraphParameter.qll
Outdated
Show resolved
Hide resolved
MathiasVP
reviewed
Jan 8, 2024
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * The control flow graph library (`codeql.swift.controlflow`) has been transitioned to use the shared implementation from the `codeql/controlflow` qlpack. No result changes are expected due to this change. |
There was a problem hiding this comment.
I'm not sure I would have put a change note here (since no users are expected to notice this change), but I guess it doesn't hurt 😄
There was a problem hiding this comment.
Ah, that's my fault - I asked for a change note because the check was failing, without thinking about whether should have just added the flag to say that one is not required. I agree it doesn't do any harm.
swift/ql/lib/codeql/swift/controlflow/internal/ControlFlowGraphParameter.qll
Outdated
Show resolved
Hide resolved
| @@ -1,3 +1,252 @@ | |||
| #-----| ... = ... | |||
There was a problem hiding this comment.
Awesome! Are these changes all from a9c9170?
bf31913
to
ec6d8da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.