Clarify concurrency cancel-in-progress behaviour #30647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
9b41d40
to
ab0beb4
Compare
|
@rvesse Thanks so much for opening a PR and linking to your issue! I'll get this triaged for review ✨ |
ab0beb4
to
05b6eb4
Compare
05b6eb4
to
581b320
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The section on GitHub Actions concurrency did not cover whether cancel-in-progress could use an expression and several discussions exists expressing confusion around this. This commit aims to clarify this part of the documentation and include an explicit example of using an expression for cancel-in-progress. It also adds clarifying language so that it is clear that even when cancel-in-progress is, or evaluates to, false, that there can still only be at most 1 running and 1 pending job in any given concurrency group.
581b320
to
f6bd7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The section on GitHub Actions concurrency did not cover whether
cancel-in-progresscould use an expression and several open discussions exists expressing confusion around this e.g.Closes: #30645
What's being changed (if available, include any code snippets, screenshots, or gifs):
This commit aims to clarify this part of the documentation and include an explicit example of using an expression for
cancel-in-progressIt also adds clarifying language so that it is clear that even when
cancel-in-progressis, or an expression that evaluates to,false, that there can still only be at most 1 running and 1 pending job in any given concurrency group.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.For content changes, I have completed the self-review checklist.