Swift: switch to shared, parameterized CFG library #15219
Conversation
swift/ql/lib/codeql/swift/controlflow/internal/ControlFlowGraphParameter.qll
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Looks good, but there are some odds and ends to finish:
- needs a change note and autoformat.
- fix for the
CfgConsistencytests (it looks like they're trying toimportan old file). - plus see my two comments
abovebelow. - then a DCA run to check for regressions / build confidence.
| @@ -0,0 +1,69 @@ | |||
| import swift | |||
There was a problem hiding this comment.
It would be good to have a comment explaining what this file is. It appears to create the CfgImpl module from the shared codeql.controlflow.Cfg library, via an input signature that is also defined here.
There was a problem hiding this comment.
I'm not really happy with the name either. I'm tempted to merge the file with ControlFlowGraphImplSpecific.
There was a problem hiding this comment.
I think merging this file with ControlFlowGraphImplSpecific is a great idea!
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * The control flow graph library (`codeql.swift.controlflow`) has been transitioned to use the shared implementation from the `codeql/controlflow` qlpack. No result changes are expected due to this change. |
There was a problem hiding this comment.
I'm not sure I would have put a change note here (since no users are expected to notice this change), but I guess it doesn't hurt 😄
There was a problem hiding this comment.
Ah, that's my fault - I asked for a change note because the check was failing, without thinking about whether should have just added the flag to say that one is not required. I agree it doesn't do any harm.
| @@ -0,0 +1,69 @@ | |||
| import swift | |||
There was a problem hiding this comment.
I think merging this file with ControlFlowGraphImplSpecific is a great idea!
| @@ -1,3 +1,252 @@ | |||
| #-----| ... = ... | |||
There was a problem hiding this comment.
Awesome! Are these changes all from a9c9170?
No description provided.