Skip to content

gh-112387: Fix error positions for decoded strings with backwards tokenize errors #112409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2023
Merged

gh-112387: Fix error positions for decoded strings with backwards tokenize errors #112409

merged 1 commit into from
Nov 27, 2023
+10 −0

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 25, 2023 •
edited
Loading

@pablogsal
pythongh-112387: Fix error positions for decoded strings with backwar…
3c43ee8 
…ds tokenize errors

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Nov 25, 2023
Closed
@pablogsal pablogsal added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 25, 2023
lysnikolaou
lysnikolaou approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal merged commit 45d6485 into python:main Nov 27, 2023
@pablogsal pablogsal deleted the gh-112387 branch November 27, 2023 18:37
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2023
@pablogsal @miss-islington
pythongh-112387: Fix error positions for decoded strings with backwar…
d961cd3 
…ds tokenize errors (pythonGH-112409)

(cherry picked from commit 45d6485)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 27, 2023

GH-112468 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2023
@pablogsal @miss-islington
pythongh-112387: Fix error positions for decoded strings with backwar…
07e457f 
…ds tokenize errors (pythonGH-112409)

(cherry picked from commit 45d6485)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 27, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 27, 2023

GH-112469 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 27, 2023
pablogsal added a commit that referenced this pull request Nov 27, 2023
@miss-islington @pablogsal
[3.12] gh-112387: Fix error positions for decoded strings with backwa…
7140716 
…rds tokenize errors (GH-112409) (#112468)

gh-112387: Fix error positions for decoded strings with backwards tokenize errors (GH-112409)
(cherry picked from commit 45d6485)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Nov 27, 2023
@miss-islington @pablogsal
[3.11] gh-112387: Fix error positions for decoded strings with backwa…
390a5b8 
…rds tokenize errors (GH-112409) (#112469)

gh-112387: Fix error positions for decoded strings with backwards tokenize errors (GH-112409)
(cherry picked from commit 45d6485)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@pablogsal @aisk
pythongh-112387: Fix error positions for decoded strings with backwar…
25c63a2 
…ds tokenize errors (python#112409)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal @Glyphack
pythongh-112387: Fix error positions for decoded strings with backwar…
993a8fc 
…ds tokenize errors (python#112409)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablogsal @lysnikolaou