Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: test demonstrating the need for phi nodes #14861

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Python: test demonstrating the need for phi nodes #14861

wants to merge 3 commits into from
+114 −0

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Nov 21, 2023

or a dataflow node playing that role, at least.

@yoff
Python: test demonstrating the need for phi nodes
4857960 
or a dataflow node playing that role, at least.
@yoff yoff added the no-change-note-required This PR does not need a change note label Nov 21, 2023
@yoff yoff requested a review from a team as a code owner November 21, 2023 14:40
@yoff yoff mentioned this pull request Nov 21, 2023
Merged
@yoff yoff mentioned this pull request Nov 21, 2023
Open
RasmusWL
RasmusWL requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but I like the naming in #14858 better.

Can we rename the new test folder to be def-use-flow instead to keep things consistent?

@yoff yoff requested a review from RasmusWL November 21, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusWL RasmusWL Awaiting requested review from RasmusWL

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoff @RasmusWL