Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: extract AST nodes related to move semantics #14768

Merged
merged 6 commits into from Nov 14, 2023
Merged

Swift: extract AST nodes related to move semantics #14768

merged 6 commits into from Nov 14, 2023

Conversation

AlexDenisov
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Swift label Nov 13, 2023
@AlexDenisov AlexDenisov marked this pull request as ready for review November 14, 2023 14:54
@AlexDenisov AlexDenisov requested a review from a team as a code owner November 14, 2023 14:54
@MathiasVP
Copy link
Contributor

Should CopyExpr and ConsumeExpr be hidden in the AST? I don't think these are something that users should be made familiar with (they don't have a syntactic representation, do they?)

@AlexDenisov
Copy link
Contributor Author

Should CopyExpr and ConsumeExpr be hidden in the AST? I don't think these are something that users should be made familiar with (they don't have a syntactic representation, do they?)

I think they should be visible, copy, consume, and _borrow are visible language keywords (_borrow is experimental for the time being though).

@MathiasVP
Copy link
Contributor

I think they should be visible, copy, consume, and _borrow are visible language keywords (_borrow is experimental for the time being though).

Oh! I see. I had missed this 😂. Thanks for the explanation 🙇

redsun82
redsun82 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MathiasVP
MathiasVP approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry, I posted a review where I asked for some updated QLDoc, but I read the QLDoc incorrectly. All is well!

@AlexDenisov AlexDenisov merged commit 57f1f5b into main Nov 14, 2023
18 of 19 checks passed
@AlexDenisov AlexDenisov deleted the alexdenisov/move-semantics branch November 14, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redsun82 redsun82 redsun82 approved these changes

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
documentation Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexDenisov @MathiasVP @redsun82