Restructure go Makefile: Build the per-platform target. #14718
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default build target we use to build the go extractor to use th per-platform targets (requires internal change to follow up). This also builds the macos target as universal binary.
smowton
reviewed
Nov 8, 2023
Comment on lines
+72
to
+73
| lipo -create $@.amd64 $@.arm64 -output $@ | ||
| rm $@.amd64 $@.arm64 |
There was a problem hiding this comment.
Suggested change
| lipo -create $@.amd64 $@.arm64 -output $@ | |
| rm $@.amd64 $@.arm64 | |
| lipo -create ../$@.amd64 ../$@.arm64 -output ../$@ | |
| rm ../$@.amd64 ../$@.arm64 |
There was a problem hiding this comment.
My understanding is that go -C extractor changes the working directory (hence the ../), but lipo and rm run one level up (as compared to the go working directory), and that's why the ../ is not needed here.
Indeed, you can see the build produces a working distribution on the internal PR.
smowton
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default build target we use to build the go extractor to use the per-platform targets (requires internal change to follow up). This also builds the macos target as universal binary.