Skip to content

Python: switch regex location tests to inline expectations #14307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yoff merged 1 commit into from
Sep 25, 2023
Merged

Python: switch regex location tests to inline expectations #14307

yoff merged 1 commit into from
Sep 25, 2023

Conversation

@yoff
Copy link
Contributor

@yoff yoff commented Sep 25, 2023

No description provided.

@yoff yoff added the no-change-note-required This PR does not need a change note label Sep 25, 2023
@yoff yoff requested a review from a team as a code owner September 25, 2023 09:48
max-schaefer
max-schaefer approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@max-schaefer max-schaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yoff yoff merged commit c9976cf into github:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@max-schaefer max-schaefer max-schaefer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@max-schaefer max-schaefer

Labels

no-change-note-required This PR does not need a change note Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoff @max-schaefer