Refresh variables with new variable formatters #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42b099c to
c81b03c
Compare
Eskibear
reviewed
Apr 21, 2021
| @@ -372,6 +380,7 @@ public static RunInTerminalRequestArguments createExternalTerminal(String[] cmds | |||
| CONTINUEOTHERS("continueOthers", ThreadOperationArguments.class), | |||
| PAUSEALL("pauseAll", ThreadOperationArguments.class), | |||
| PAUSEOTHERS("pauseOthers", ThreadOperationArguments.class), | |||
| REFRESHVARIABLES("refreshVariables", RefreshVariablesArguments.class), | |||
There was a problem hiding this comment.
REFRESH_VARIABLES would be better human-readable. For consistency just leave it as is. But consider to refactor all the enums one day?
There was a problem hiding this comment.
yes, i will use a separate PR to refactor these enums.
Eskibear
previously approved these changes
Apr 21, 2021
c81b03c to
aedad56
Compare
aedad56 to
7ef7021
Compare
Eskibear
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.