Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-80667: fix case-sensitivity of some unicode literal escapes #107281

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Jul 26, 2023

This PR is a partial fix for #80667, resolving inconsistent treatment of case in Unicode literal escape sequences. This changeset should be compatible with the changes in #101585 as well as named ranges that may be introduced in the future.

Objects/unicodeobject.c Outdated Show resolved Hide resolved
@SnoopJ
Copy link
Contributor Author

SnoopJ commented Jul 26, 2023

I did not realize when I wrote this patch last night that PyOS_strnicmp() existed, I've rewritten the patch to use it instead, avoiding the issues that were caused by the string copying approach. Ready for review.

@SnoopJ SnoopJ force-pushed the bugfix/gh-80667_fix-case-sensitive-literal-escape branch from 5b0156b to abd39e4 Compare July 26, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants