New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Make flow configurations use new data flow API #13820
Open
owen-mc
wants to merge
52
commits into
github:main
Choose a base branch
from
owen-mc:go/refactor-data-flow-configurations
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Go: Make flow configurations use new data flow API #13820
owen-mc
wants to merge
52
commits into
github:main
from
owen-mc:go/refactor-data-flow-configurations
+2,311
−2,485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85baa81
to
1d2c268
Compare
1d2c268
to
028eb9b
Compare
Need to get the signatures correct.
028eb9b
to
9919221
Compare
We don't have to keep a deprecated copy as this is private. This allows us to delete a copy of the DataFlow library!
Removed edges and labels are mostly duplicates. No alerts are lost.
9919221
to
355f9c6
Compare
|
I will rebase on main when #13822 is merged, which will fix the sync files check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.