Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Exclude qualifier argument for existing models #13747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tausbn
Copy link
Contributor

@tausbn tausbn commented Jul 14, 2023

Excludes candidates for Argument[this] where we already have a model that covers a different argument of the containing call.

Excludes candadites for `Argument[this]` where we already have a model that covers a
different argument of the containing call.
@tausbn tausbn added the no-change-note-required This PR does not need a change note label Jul 14, 2023
@tausbn tausbn requested a review from a team as a code owner July 14, 2023 12:28
@github-actions github-actions bot added the Java label Jul 14, 2023
Reverts the change made in
daf2743

With the change in the aforementioned commit, we were extracting candidates for endpoints that
had a neutral _summary_ model. These are bad candidates, as they have already been triaged.
Copy link
Contributor

@kaeluka kaeluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :) <3 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants