Ruby: query to automatically extract type definitions from library code #13750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently very limited and WIP - this automatically extracts some type definitions from a library codebase in a MaD amenable format.
The first query looks at returned values from methods in the codebase and determines if they return an instance of some class that we can find. For instance, in the case of some code like:
We can determine that the return value from
get_barorget_bar_indirectlymay be aBarinstance, giving ustypeModelrows of:type1type2pathBarFooMethod[get_bar].ReturnValueBarFooMethod[get_bar_indirectly].ReturnValueThe second query looks at cases where we call some method and pass it an instance of some type. e.g. in
we get:
type1type2pathSome::DatabaseFooMethod[execute_with_database].Parameter[0]This is heavily WIP at the moment - many of the limitations are TODOs in the code, but as a quick list of things that are not yet supported or need additional work:
SomeClass.new