Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problemMatcher patterns for the watch task (#1136) #1137

Merged
merged 1 commit into from Mar 16, 2022
Merged

Fix problemMatcher patterns for the watch task (#1136) #1137

merged 1 commit into from Mar 16, 2022

Conversation

sbj42
Copy link
Contributor

@sbj42 sbj42 commented Mar 15, 2022

Webpack output patterns have changed since these patterns were written,
without this change the default launch config hangs.

Fixes #1136

@sbj42
Fix problemMatcher patterns for the watch task
836feff 
Webpack output patterns have changed since these patterns were written,
without this change the default launch config hangs.
@sbj42 sbj42 force-pushed the sbj42/fix-launch-task branch from 7d49806 to 836feff Compare Mar 16, 2022
testforstephen
testforstephen approved these changes Mar 16, 2022
View changes
Copy link
Contributor

@testforstephen testforstephen left a comment

LGTM

@testforstephen
Copy link
Contributor

testforstephen commented Mar 16, 2022

@sbj42 It's a good fix, thanks for the contribution.

@testforstephen testforstephen merged commit ccb90c2 into microsoft:main Mar 16, 2022
4 checks passed
@sbj42 sbj42 deleted the sbj42/fix-launch-task branch Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testforstephen testforstephen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Launch Extension' launch configuration hangs
2 participants
@sbj42 @testforstephen