Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl user error exception #128

Closed
wants to merge 9 commits into from
Closed

impl user error exception #128

wants to merge 9 commits into from

Conversation

@andxu
Copy link
Collaborator

@andxu andxu commented Dec 11, 2017

  1. refactor the error handling for ResolveClasspathsHandler
2. refactor the error handling for ResolveClasspathsHandler
@andxu
Copy link
Collaborator Author

@andxu andxu commented Dec 11, 2017

#55

@andxu
Copy link
Collaborator Author

@andxu andxu commented Dec 11, 2017

#85

package com.microsoft.java.debug.core;

public class UserErrorException extends DebugException {
private static final long serialVersionUID = -6001456457602995764L;

This comment has been minimized.

@yaohaizh

yaohaizh Dec 11, 2017

What is this magic number for? Please comment it

This comment has been minimized.

@andxu

andxu Dec 11, 2017
Author Collaborator

serialVersionUID is generated by eclipse using random number, it is used serialization orelse there will be a compilation warning.

private static final long serialVersionUID = -6001456457602995764L;

/**
* Create an user error exception indicates an user setting/operation is illegal by design.

This comment has been minimized.

andxu added 3 commits Dec 11, 2017
package com.microsoft.java.debug.core;

public class UserErrorException extends DebugException {
private static final long serialVersionUID = -6001456457602995764L;

This comment has been minimized.

@yaohaizh

yaohaizh Dec 11, 2017

Naming convention for final static

if (javaProject == null) {
throw new CoreException(new Status(IStatus.ERROR, JavaDebuggerServerPlugin.PLUGIN_ID,
String.format("The project '%s' is not a valid java project.", projectName)));
private static IJavaProject getJavaProjectFromName(String projectName) throws DebugException {

This comment has been minimized.

@yaohaizh

yaohaizh Dec 11, 2017

Could we make this as a Utility class?

This comment has been minimized.

@andxu

andxu Dec 11, 2017
Author Collaborator

It is in jinbo's change.

This comment has been minimized.

@andxu

andxu Dec 13, 2017
Author Collaborator

JdtUtils.getJavaProjectFromName doesn't have the right error message for not-existing projects and non-java projects.

andxu added 5 commits Dec 11, 2017
@andxu andxu closed this Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.