Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: route compiler diagnostics through our log #12760

Draft
wants to merge 1 commit into
base: redsun82/swift-logging
Choose a base branch
from
Draft

Swift: route compiler diagnostics through our log #12760

wants to merge 1 commit into from

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Apr 4, 2023

No description provided.

@redsun82 redsun82 requested a review from sashabu April 4, 2023 15:23
@github-actions github-actions bot added the Swift label Apr 4, 2023
sashabu
sashabu approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@sashabu sashabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please hold off on merging until the base PR is merged (or at least ready to merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashabu sashabu sashabu approved these changes

@github/codeql-swift codeql-swift

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redsun82 @sashabu